Skip to content

Add RDP (readout protection) support for STM32L4x flash #61378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 20, 2023
Merged

Add RDP (readout protection) support for STM32L4x flash #61378

merged 2 commits into from
Oct 20, 2023

Conversation

@rlezuo1
Copy link
Contributor

@rlezuo1 rlezuo1 commented Aug 10, 2023

Add support for Flash readout protection on the STM32L4x series

@rlezuo1 rlezuo1 marked this pull request as ready for review August 10, 2023 14:24
de-nordic
de-nordic previously requested changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@de-nordic de-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I can see is that the provided functions are not used anywhere, there is no test for them there is no sample, and they have no external declarations provided.
What are they for?
If they are for users, then they should be implemented as flash_ex_op, as a vendor extension (include/zephyr/drivers/flash/stm32_flash_api_extensions.h).
Is this similar work as here #52980 and here #53441 ?

@de-nordic de-nordic requested a review from duda-patryk August 17, 2023 11:17
@rlezuo1
Copy link
Contributor Author

rlezuo1 commented Sep 4, 2023

@de-nordic yes the work is similar to the PRs you've referenced, it implements one of the features (RDP) on another ST part following the spirit of the existing code.
I agree that samples and tests are missing (as for the existing code).
Testing this requires real hardware, a sample could be provided, looks like this, wouldn't know where to add it though.

        struct flash_stm32_ex_op_rdp rdp_in = {
            .enable = true,
            .permanent = false
        };
        struct flash_stm32_ex_op_rdp rdp_out;

        if (flash_ex_op(flash, FLASH_STM32_EX_OP_RDP, (uintptr_t)&rdp_in, &rdp_out) != 0) {
            LOG_ERR("RDP level NOT set");
        } else {
            LOG_INF("RDP levels: enable=%d permanent=%d", rdp_out.enable, rdp_out.permanent);
        }

@semihalf-duda-patryk any suggestions/ideas on this one?

@erwango
Copy link
Member

erwango commented Sep 4, 2023

I agree that samples and tests are missing (as for the existing code).

Tests are available in tests/drivers/flash/stm32/src/main.c

@rlezuo1 rlezuo1 force-pushed the add_stm32l4x_rdp branch 2 times, most recently from 6b72f78 to 70fdbb7 Compare September 6, 2023 16:41
@rlezuo1 rlezuo1 requested a review from de-nordic September 7, 2023 06:53
erwango
erwango requested changes Sep 11, 2023
View reviewed changes
erwango
erwango requested changes Sep 11, 2023
View reviewed changes
@rlezuo1 rlezuo1 requested a review from erwango September 12, 2023 08:59
erwango
erwango previously approved these changes Sep 12, 2023
View reviewed changes
de-nordic
de-nordic reviewed Sep 12, 2023
View reviewed changes
de-nordic
de-nordic reviewed Sep 12, 2023
View reviewed changes
duda-patryk
duda-patryk reviewed Sep 12, 2023
View reviewed changes
@rlezuo1 rlezuo1 requested a review from de-nordic September 12, 2023 15:26
@rlezuo1
Copy link
Contributor Author

rlezuo1 commented Sep 18, 2023

@de-nordic I believe the change-requests you had have been addressed is there still something missing?

@rlezuo1
drivers: flash: Add RDP (readout protection) support for STM32L4x flash
74c4eb4 
Add support for Flash readout protection on the STM32L4x series

Signed-off-by: Roland Lezuo <[email protected]>
@rlezuo1 rlezuo1 force-pushed the add_stm32l4x_rdp branch 2 times, most recently from 7dfabc9 to 0cfff2d Compare October 3, 2023 17:36
@de-nordic de-nordic dismissed their stale review October 3, 2023 18:00

re-review

@rlezuo1
Copy link
Contributor Author

rlezuo1 commented Oct 12, 2023

@semihalf-duda-patryk @erwango friendly reminder

@erwango erwango added this to the v3.6.0 milestone Oct 12, 2023
erwango
erwango reviewed Oct 12, 2023
View reviewed changes
erwango
erwango requested changes Oct 12, 2023
View reviewed changes
@rlezuo1
test: drivers: flash: Add RDP (readout protection) tests for STM32L4x
6fb615a 
Add device tests (successfully executed locally)

Signed-off-by: Roland Lezuo <[email protected]>
@rlezuo1 rlezuo1 requested a review from erwango October 12, 2023 13:25
duda-patryk
duda-patryk reviewed Oct 12, 2023
View reviewed changes
@rlezuo1
Copy link
Contributor Author

rlezuo1 commented Oct 12, 2023

@de-nordic friendly poke - with your approval the PR can be merged ...

@rlezuo1
Copy link
Contributor Author

rlezuo1 commented Oct 15, 2023

@erwango friendly poke: can you merge this PR?

@erwango
Copy link
Member

erwango commented Oct 16, 2023

@erwango friendly poke: can you merge this PR?

No. We're in feature freeze for V3.5.0 stabilisation period. It will have to wait until merge window is open again.
See https://github.com/zephyrproject-rtos/zephyr/wiki/Release-Management

@rlezuo1
Copy link
Contributor Author

rlezuo1 commented Oct 16, 2023

@erwango full ack, sorry for the noise

@carlescufi carlescufi merged commit b97376d into zephyrproject-rtos:main Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erwango erwango erwango approved these changes

@duda-patryk duda-patryk duda-patryk approved these changes

@de-nordic de-nordic de-nordic approved these changes

@nashif nashif Awaiting requested review from nashif

@ABOSTM ABOSTM Awaiting requested review from ABOSTM

@Desvauxm-st Desvauxm-st Awaiting requested review from Desvauxm-st

@FRASTM FRASTM Awaiting requested review from FRASTM

@gautierg-st gautierg-st Awaiting requested review from gautierg-st

@GeorgeCGV GeorgeCGV Awaiting requested review from GeorgeCGV

Assignees

@de-nordic de-nordic

Labels

area: Flash platform: STM32 ST Micro STM32

Projects

None yet

Milestone

v3.6.0

Development

Successfully merging this pull request may close these issues.

6 participants

@rlezuo1 @erwango @duda-patryk @de-nordic @carlescufi @zephyrbot